Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project_name parameter to the kubernetes module #333

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Add project_name parameter to the kubernetes module #333

merged 2 commits into from
Jan 2, 2024

Conversation

raman-babich
Copy link
Contributor

SUMMARY

Fixes #264

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

digital_ocean_kubernetes

ADDITIONAL INFORMATION

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (23f775f) 62.52% compared to head (91b350e) 62.81%.

Files Patch % Lines
plugins/modules/digital_ocean_kubernetes.py 58.82% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   62.52%   62.81%   +0.29%     
==========================================
  Files          46       46              
  Lines        3602     3617      +15     
  Branches      738      743       +5     
==========================================
+ Hits         2252     2272      +20     
+ Misses       1059     1050       -9     
- Partials      291      295       +4     
Flag Coverage Δ
integration 65.41% <35.29%> (+0.02%) ⬆️
sanity 26.01% <0.00%> (-0.11%) ⬇️
units 60.64% <23.52%> (-1.71%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mamercad
Copy link
Collaborator

Try rebasing because of #335 please.

@mamercad
Copy link
Collaborator

mamercad commented Jan 1, 2024

@raman-babich apologies for pushing to your branch; I'm in the process of refactoring the integration testing workflows (and having this PR open is helping me). I've reworked the integration testing workflows to matrix over the various modules (versus having all of their outputs in a single pass). There are quite a few modules in this collection at this point, and although the output in the PR becomes very noisy, it's helpful to be able to quickly figure out which module(s) are failing.

Copy link
Collaborator

@mamercad mamercad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@mamercad mamercad merged commit c09252e into ansible-collections:main Jan 2, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add project_name parameter support for kubernetes cluster
2 participants